perf: extend_fallback optimization - #567
Conversation
|
oh yeah this brings it to the v1 performance baseline it's similar to what I did in #405 |
|
I have stopped optimizing for performance really, the codebase is so bloated, we need to first restructure it |
alejandro-vaz
left a comment
There was a problem hiding this comment.
terrible for the codebase, good for performance
|
It is my last perf related contribution hopefully 😂, I'll switch to refactoring. I promise(pinky). |
|
I'm not sure how we are going to approach simplifying the codebase I just tried to make the |
|
I'll do the trusted len now, for the cold reserve give me few days to think about it in background. |
|
oh are we missing trustedlen implementations?? |
|
I'm sorry that was a brain hiccup, this happens when you do to many PRs 😂, I meant |
|
Btw |
|
yeah I spent too much time on nightly that |
This optimizes
extend_fallbackwith some unsafe code. I tried to document the unsafe behavior as much as possible to avoid future mistakes.Benchmark results: